[SPARK-8199][SQL] follow up; revert change in test #7505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@tarekauel If Calendar is created inside for-loop (i), we should use |
Contributor
|
there are four more places (below that) need to be fixed. |
Contributor
|
After this rush, you should have more rest, also me. :) |
Contributor
Author
|
Now it's right, isn't it? |
Contributor
|
LGTM. |
|
Test build #1113 has finished for PR 7505 at commit
|
Contributor
|
Thanks - I've merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rxin / @davies
Sorry for that unnecessary change. And thanks again for all your support!